Update package inspector to generate SHA-512 along with SHA-1 #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate variable names for clarity
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
p3dr0rv
added
No-Changelog
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the package inspector by adding SHA-512 hash generation alongside the existing SHA-1 output and suppresses a CodeQL SM05136 warning in MSAL.
- Renamed
packageSigningShatosigningCertificateHashesand included SHA-512 calculation inMainActivity. - Annotated legacy SHA-1 usage with a CodeQL suppression in
PublicClientApplicationConfiguration. - Updated message composition to display both hash values.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package-inspector/src/main/java/com/microsoft/inspector/MainActivity.java | Renamed variable, added SHA-512 digest, updated message assignment. |
| msal/src/main/java/com/microsoft/identity/client/PublicClientApplicationConfiguration.java | Added CodeQL suppression comment for SHA-1 instantiation. |
Comments suppressed due to low confidence (2)
package-inspector/src/main/java/com/microsoft/inspector/MainActivity.java:148
- The comment "This is only for test purposes, not used in production" is misleading; update it to reflect that SHA-1 is retained for legacy support in production.
final MessageDigest digestSha1 = MessageDigest.getInstance("SHA"); // CodeQL [SM05136] This is only for test purposes, not used in production.
package-inspector/src/main/java/com/microsoft/inspector/MainActivity.java:156
- Consider adding or updating unit tests to verify both SHA-1 and SHA-512 hash generation to ensure the new SHA-512 logic is covered.
signingCertificateHashes = "SHA-1: " + packageSigningSha1 + "\nSHA-512: " + packageSigningSha512;
package-inspector/src/main/java/com/microsoft/inspector/MainActivity.java
Outdated
Show resolved
Hide resolved
package-inspector/src/main/java/com/microsoft/inspector/MainActivity.java
Outdated
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/client/PublicClientApplicationConfiguration.java
Show resolved
Hide resolved
…tivity.java Co-authored-by: Copilot <[email protected]>
…tivity.java Co-authored-by: Copilot <[email protected]>
melissaahn
approved these changes
Jul 1, 2025
fadidurah
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I suppress a CodeQL regarding the use of SHA-1, why because we are still using sha1 in the redirect urls and we cannot force apps to update the signature.